Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability for users to provide application archives folder to upload th… #327

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

sshingav-tibco
Copy link
Collaborator

****What's this Pull request about?

Ability for users to provide application archives folder to upload the EAR in domain.
This is an enhancement, where can add external EAR location as "externalEarLoc" in the config file.

****Which Issue(s) this Pull Request will fix?

#276 Ability for users to provide application archives folder to upload the EAR in domain.

****Does this pull request maintain backward compatibility?
Yes

****How this pull request has been tested?

Mention the test scenarios.

  1. Successfully able to deploy the application with config file providing external EAR location.
  2. Successfully able to deploy the application with the config file without providing external EAR location.
  3. Successfully able to deploy the application without a config file. (reading POM)

****Any background context or comments you want to provide?

I have added one property called "externalEarLoc" in BWEARInstallerMojo.
Whenever the deployment config file is provided, It will check for the external EAR location. If the "externalEarLoc" is present it will copy the generated EAR from the target folder to the provided folder and successfully deploy the application.

@SujataDarekar
Copy link
Contributor

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants