Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Basic Authentication workflow #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

calsocrates
Copy link

We ran into a bug in production where assets for reports weren't loading when a url in the form of http://{user}:{password}@www.myurl.com. According the RFC, this is a legal URL format and browsers such as chrome will automatically handle the addition of the request headers without intervention from the user. The current code doesn't send up any headers at all.

This PR will allow for the loading of objects where the URL is in the above form.

@teodord
Copy link
Collaborator

teodord commented Jul 7, 2020

Can you provide a link to the RFC you mentioned?

@teodord
Copy link
Collaborator

teodord commented Jul 7, 2020

Also, can you also provide some JRXML so that we can see in which expressions you are using this feature and what type of value the expression has?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants