Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue-17, iText 2.1.7 to OpenPDF 1.3.11 #53

Closed
wants to merge 2 commits into from

Conversation

srbala
Copy link

@srbala srbala commented Mar 11, 2019

Resolves issue #17, replaces outdated and partial PR #29.

@srbala
Copy link
Author

srbala commented Mar 11, 2019

This also related to LibrePDF/OpenPDF#145, solves JasperReport support

@ozawa-hi
Copy link

ozawa-hi commented Apr 8, 2019

Can you provide a binary distribution of JasperReports library with OpenPDF? I still can't compile JasperReports with the changes you've provided.

@andreasrosdal
Copy link

@ozawa-hi Please share the compilation error that you get.

@srbala Can you please update this PR to the latest version of OpenPDF, which is 1.2.15 now?

@ozawa-hi
Copy link

Sorry my bad. Got it to build. Thanks.

@ozawa-hi
Copy link

I think TIBCO Jaspersoft is sticking with itext2.1.7 because of reasons written in the following page.
https://community.jaspersoft.com/wiki/issue-concerning-itext-licensing-tibco-jaspersoft

@shamimOnGitHub
Copy link

Hi ozawa-hi,

Were you able to run JasperReports using OpenPDF. How did you compile?

@andreasrosdal
Copy link

Any news on this? The latest version of OpenPDF is now 1.3.11. Maybe this pull request could be updated?

@ozawa-hi All the issues mentioned on that page are now addressed by OpenPDF. We have done a code review and resolved all questions related to licensing.
More info here: https://github.com/LibrePDF/OpenPDF/wiki/OpenPDF---License-MPL---LGPL-background-info

@douph1
Copy link

douph1 commented Dec 19, 2019

Hi @teodord,

you have closed #17

When the situation will change in the future, we'll reconsider.

but you reference this PR #53 in #29

Does it mean that there is a reconsideration ?
If not, why not close all PR ( and not just duplicate) about openpdf dependencies as wont-fix ?

@teodord
Copy link
Collaborator

teodord commented Dec 19, 2019

We'll probably keep only one of these items open for the foreseeable future, as we cannot completely exclude that one day will make the switch.

@srbala srbala changed the title Fix issue-17, iText 2.1.7 to OpenPDF 1.2.11 Fix issue-17, iText 2.1.7 to OpenPDF 1.3.11 Dec 25, 2019
@srbala
Copy link
Author

srbala commented Dec 25, 2019

@andreasrosdal updated OpenPDF to 1.3.11
@teodord resolved merge conflicts, this pull is ready for merge

@srbala srbala requested a review from teodord January 31, 2020 22:22
@paksboda
Copy link

paksboda commented Jul 7, 2020

@teodord
Do we have plan to merge this anytime soon? We are using JasperReport and we want to migrate to OpenPDF. This is what we exactly need.

@teodord
Copy link
Collaborator

teodord commented Jul 7, 2020

My understanding is that you can put OpenPDF in your application classpath instead of iText and it should work just fine.
If you look at the proposed changes, none are about Java source code modifications and are only about JAR references.
So you can do what you need to do without JasperReports project actually making any change itself.

@paksboda
Copy link

paksboda commented Jul 7, 2020

Thanks for response.
I agree with you and if not merged then I will do the same thing but if merge is happening anytime soon then it will be more cleaner implementation so I thought to confirm once.

@OleksandrShkurat
Copy link

Looks like this PR is outdated

@teodord
Copy link
Collaborator

teodord commented Mar 6, 2023

A fork of OpenPDF 1.3.30 is going to be used in the next JasperReports Library release.

@OleksandrShkurat
Copy link

OleksandrShkurat commented Mar 6, 2023

A fork of OpenPDF 1.3.30 is going to be used in the next JasperReports Library release.

That's why I said this PR is outdated. I'd suggest closing it

@dadza
Copy link
Collaborator

dadza commented Mar 10, 2023

Closing, iText has been replaces with a OpenPDF 1.3.30 patched dependency.

@dadza dadza closed this Mar 10, 2023
@soc
Copy link

soc commented Mar 24, 2023

@teodord Is there any information available on the differences of the forked OpenPDF vs. mainline OpenPDF? (Are there any compatibility concerns when replacing the forked one with the mainline one locally?)

@dadza
Copy link
Collaborator

dadza commented Mar 24, 2023

The only difference is that our forked version includes a fix for LibrePDF/OpenPDF#676

You can use the official OpenPDF 1.3.30 release if you don't mind the effects of that bug.

@soc
Copy link

soc commented Mar 24, 2023

@dadza Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants