Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for two issues for spotfire integration #471

Open
wants to merge 1 commit into
base: snappy/master
Choose a base branch
from

Conversation

kneeraj
Copy link

@kneeraj kneeraj commented Apr 11, 2019

Changes proposed in this pull request

  1. error in select if table(replicated) being created with backticks as delimiter.
  2. insert into default database failing because default is reserved key word in store layer.

Patch testing

Manual

Is precheckin with -Pstore clean?

In Progress.

ReleaseNotes changes

(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?)

Other PRs

1. error in select if table(replicated) being created with backticks as delimiter.
2. insert into default database failing because default is reserved key word in store layer.
@kneeraj kneeraj requested review from sumwale and bisenpiyush April 11, 2019 13:53
Copy link

@sumwale sumwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kneeraj pushed a commit that referenced this pull request Apr 13, 2019
kneeraj pushed a commit that referenced this pull request Jul 3, 2019
ashetkar pushed a commit that referenced this pull request Sep 24, 2020
sumwale pushed a commit to sumwale/snappy-store that referenced this pull request Apr 30, 2021
@sumwale sumwale force-pushed the snappy/master branch 2 times, most recently from 337768c to ec453a6 Compare April 8, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants