Analysis Fixes: Graphs now scale + render time in Myanmar/Yangon time zone #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,14 +15,14 @@ module.exports = function renderHateSpeechReportGraph(id, data, range, descripti | |||
| d.value + | |||
| " Reports" + | |||
| "</div><div>" + | |||
| d3.timeFormat("%b. %d %H:00")(d.date).replace(/\s0/g, " ") + | |||
| moment(d.data.date).tz("Asia/Yangon").format('MMM. Do hh:mm:ss') + | |||
There was a problem hiding this comment.
I should have said this earlier but I think since the Myanmar project is over, do we still want to make this change? We can maybe just make this change on the Myanmar server and not aggie repo. Lmk if I am missing somthing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix graphs going off the screen, and the time zones being based on local user time. Note that I've added
moment-timezoneto the package.json, so you'll need tonpm ifor this one.