Move files from main app to api project #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghareeb-falazi
requested changes
Feb 2, 2022
Member
ghareeb-falazi
left a comment
ghareeb-falazi
left a comment
There was a problem hiding this comment.
Please consider the comments
src/main/java/blockchains/iaas/uni/stuttgart/de/api/IAdapterExtenstion.java
Outdated
Show resolved
Hide resolved
src/main/java/blockchains/iaas/uni/stuttgart/de/api/contracts/Permissions.java
Outdated
Show resolved
Hide resolved
| <artifactId>core</artifactId> | ||
| <version>4.5.6</version> | ||
| </dependency> | ||
| <dependency> |
Member
There was a problem hiding this comment.
Could you make sure that all dependencies in this pom file are actually used? For example, intuitively I think that rpc.server is not needed by this repository, but I might be wrong
Collaborator
Author
There was a problem hiding this comment.
Yes, all the added dependencies are used in the project. Although, I have added exclusions as they were in the main app repository.
src/main/java/blockchains/iaas/uni/stuttgart/de/api/AbstractAdapter.java
Outdated
Show resolved
Hide resolved
...java/blockchains/iaas/uni/stuttgart/de/api/connectionprofiles/ConnectionProfileListener.java
Outdated
Show resolved
Hide resolved
...java/blockchains/iaas/uni/stuttgart/de/api/connectionprofiles/AbstractConnectionProfile.java
Show resolved
Hide resolved
ghareeb-falazi
approved these changes
Feb 8, 2022
Member
ghareeb-falazi
left a comment
ghareeb-falazi
left a comment
There was a problem hiding this comment.
Everything looks good to me at this stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.