added poi able to update & added try-except to print_log def #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's nice
It's always nice to have a log to show who updated which chunks. If you think it loves to fails in your environment, you can added a try-except surrounding the file writing opertaion and also, you don't need to handle the version bump |
skuzow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly when a region is updated, and in the destination world where it's updated there are existing poi there. If that's the case with this change the poi will change, instead of not changing and staying in the air invisible. And if in the source world the poi doesn't exists poi will be deleted in the destination world.
I noticed this function doesn't work properly and makes some errors, so I think it's a good idea to erase it, because it's not necessary at all.