Nearby elements icons #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarfonts
requested changes
Apr 10, 2024
|
|
||
| const template = fs.readFileSync("index-template.html").toString(); | ||
|
|
||
| const { icons } = config; |
There was a problem hiding this comment.
Si se quiere ser modenno, este bloque se podría escribir con un reduce:
// Group icons by category
const categories = config.icons.reduce((categories, icon) => {
if (!categories[icon.category]) {
categories[icon.category] = [];
}
categories[icon.category].push(icon);
}, {});| @@ -8,7 +8,8 @@ | |||
| "static" | |||
| ], | |||
| "scripts": { | |||
| "clean": "rm -rf src static", | |||
| "clean": "rm -rf src static dist", | |||
| "update-icons": "node ./scripts/update-icons.js", | |||
| "svg2png": "cd scripts && ./svg2png.js", | |||
There was a problem hiding this comment.
este script es lento y además no está convirtiendo bien las imágenes de mete(aparecen unos caracteres extraños en una esquina).
Instalar sharp-cli y usar aquí el comando sharp-cli -i svg/*.svg -o static/png/. Desinstalar la dependencia svg2png, borrar script y actualizar readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new icons for transit core (multiple transport providers: fgc, rodalies, ambici...)
new line icons by transit namespace
new update icons script, from s3 repository (mantained internally with a backoffice)
new index, show icons grouped by category and allows filter by format and resize icons