Change matching of name and fullname patterns to exact match by default #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name and full name of types, if they are exactly equal. Previously it also matched if the name contained the pattern. One problem with this was for example that the name of a parent namespaces matched to all child namespaces. Signed-off-by: Fritz Brandhuber <fritz.brandhuber@tngtech.com>
|
To migrate tests which break because of this change, it should be enough to specifically enable regex matching in all problematic cases. Then the tests should behave as they did previously. |
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If regex use is not explicitly specified, patterns now only match the name and full name of types, if they are exactly equal. Previously it also matched if the name contained the pattern. One problem with this was for example that the name of a parent namespaces matched to all child namespaces.