-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove log4j usage #38
Comments
I have moved "slf4j-log4j12" to "test" scope which causes
while executing tests. @janschaefer do you have any clue why as it there should be an implementation on classpath while executing tests, isn' it? |
Analysing this "problem" further, it seems that just the "slf4-jog4j12" test dependency is not handled transitive in the other subprojects, even if "jgiven-core/test-jar" is required as dependency ... this is because Maven is not designated for that, see https://jira.codehaus.org/browse/MNG-1378 :-( |
@aaschmid thanks for looking into that! |
If I see it correctly, the Maven defect is already 9 years old and not fixed yet! I will have a look whether we can get rid of the test-jar dependency altogether. |
This also finally convinced me that we should actually switch to Gradle #39 |
I have merged the branch into master and deleted it. |
In com.tngtech.jgiven.impl.util.ReflectionUtil there is a reference to log4j. This seems to be inconsistent with the usage of slf4j in the rest of the project. This means I can't use JGiven in a project that uses a different slf4j back-end.
Switching to the slf4j Logger seems to be trivial.
The text was updated successfully, but these errors were encountered: