Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't show multiple indexed attachments when cases are not shown as table #207

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented May 30, 2016

I have a parameterized test case that is not shown as a table (due to different test steps depending on the parameters).

What I see in HTML5 report of the current version (0.11.3): For every case all attachments of all cases are shown (= multiple paperclips on a single step).

What I want: Only the attachments of the current case should to be shown (without the index).

This change fixes it for me. I'm not sure if this is the optimal code change as I'm not familiar with AngularJS - but it works for me. Please feel free to refactor.

I'm looking forward to a patch release if possible.

@janschaefer
Copy link
Contributor

Fine with me, thanks for the fix!

@janschaefer janschaefer merged commit 34f4bd5 into TNG:master May 30, 2016
@janschaefer janschaefer added this to the v0.11.4 milestone May 30, 2016
@janschaefer
Copy link
Contributor

I can make a patch release for that.

@ahus1 ahus1 deleted the ahus1_don_t_show_index_attachments_in_cases_with_no_tables branch October 9, 2016 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants