Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce DualScenarioTest #406

Merged
merged 4 commits into from
Jul 28, 2019

Conversation

jangalinski
Copy link
Contributor

see #388

Motivation: keep steps for given and when in same stage so you can easily build tests that build on each other like

given().doA();
when().doB();
then().assertState();

and

given().doA().and().doB();
when().doC();
then().assertState();

Naming things was the hard part, I came up with DualScenarioTest ... if you are generally fine with the idea, I will continue adding tests and docs.

@janschaefer
Copy link
Contributor

Yeah, go ahead :-)

@jangalinski
Copy link
Contributor Author

Do you have any hints for testing? I do not see any explicit tests for the SimpleScenarioTest(Base) ... but basically, I am doing the same with the DualScenarioTest(Base) ... is it ok to skip this?

@jangalinski
Copy link
Contributor Author

I updated the adoc and mentioned DualScenarioTest where ever (2 locations) SimpleScenarioTest is mentioned already.

@jangalinski
Copy link
Contributor Author

Could you check please if this is enough or give concrete tasks that should be done before this could get in a release?

@janschaefer janschaefer merged commit 4eaa0b5 into TNG:master Jul 28, 2019
@janschaefer janschaefer added this to the v1.0.0 milestone Jul 28, 2019
janschaefer added a commit that referenced this pull request Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants