Change exception handling for TestNG (#312) #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janschaefer
force-pushed
the
testng-exception-handling
branch
2 times, most recently
from
0f6ff10
to
8e83ddf
Compare
janschaefer
force-pushed
the
testng-exception-handling
branch
from
8e83ddf
to
7efcb8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JGiven does not interact well with TestNG in case exceptions are thrown in step methods. Normally JGiven catches all exceptions to be able to report the following steps of a scenario and rethrows the exception at the end of a scenario. In JUnit this works as expected. In TestNG, however, the hook for JGiven comes too late to rethrow the exception. Thus TestNG always treats failing scenarios as success. This PR fixes this by not catching exceptions in steps anymore. The disadvantage of this is that the steps following a failed step cannot be reported anymore.