Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new guaranteed field inside a ScenarioState or a ProvidedScenarioState #700

Merged
merged 12 commits into from
Aug 3, 2021
Merged

Add new guaranteed field inside a ScenarioState or a ProvidedScenarioState #700

merged 12 commits into from
Aug 3, 2021

Conversation

andru47
Copy link
Contributor

@andru47 andru47 commented Jul 27, 2021

Fixes #268

@andru47
Add new guaranteed field inside a ScenarioState or a ProvidedScenario…
895dcc7 
…State.

Fixes #268

Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47 andru47 requested a review from l-1squared July 27, 2021 17:00
andru47 added 3 commits July 28, 2021 16:24
@andru47
Reformat ValueInjector
cbf1f9b 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47
Change location from LifecycleManager to ValueInjector
52e448f 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47
Add JGiven test to ensure order of guaranteed field verification
b7a62fd 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47 andru47 requested a review from l-1squared July 28, 2021 16:24
andru47 added 3 commits July 29, 2021 13:02
@andru47
Remove unnecessary throws statement
7716bbe 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47
Remove simple test
71542d7 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47
Add new JGiven test for guaranteed field validator order
65e370f 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47 andru47 requested a review from l-1squared July 29, 2021 14:35
@andru47
Fix test class and minor changes
6d7e124 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47 andru47 requested a review from l-1squared July 30, 2021 11:46
andru47 added 3 commits July 30, 2021 19:22
@andru47
Update changelog
589fb26 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47
Merge branch 'master' into fix-268
d8a87ad
@andru47
Fix changelog spacing
a27c79e 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
l-1squared
l-1squared reviewed Aug 2, 2021
View reviewed changes
jgiven-core/src/test/java/com/tngtech/jgiven/impl/inject/ValueInjectorTest.java Show resolved Hide resolved
jgiven-tests/src/main/java/com/tngtech/jgiven/tests/GuaranteedFieldRealTest.java
import com.tngtech.jgiven.junit.ScenarioTest;
import org.junit.Test;

public class GuaranteedFieldRealTest extends ScenarioTest<GuaranteedFieldRealTest.RealGiven, GuaranteedFieldRealTest.RealWhen, GuaranteedFieldRealTest.RealThen> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for that name :)

jgiven-tests/src/test/java/com/tngtech/jgiven/impl/GuaranteedStateTest.java Outdated Show resolved Hide resolved
l-1squared
l-1squared previously approved these changes Aug 2, 2021
View reviewed changes
@andru47
Minor changes
2cd8232 
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
@andru47 andru47 requested a review from l-1squared August 2, 2021 18:34
l-1squared
l-1squared approved these changes Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@l-1squared l-1squared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could squash & rebase your commits.

@andru47 andru47 merged commit 9a59242 into master Aug 3, 2021
@andru47 andru47 deleted the fix-268 branch August 3, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-1squared l-1squared l-1squared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a guaranteed attribute to scenario states
2 participants
@andru47 @l-1squared