Fix SVG files not having a thumbnail #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
corbym
reviewed
Aug 12, 2021
jgiven-html5-report/src/main/java/com/tngtech/jgiven/report/html5/Html5AttachmentGenerator.java
Outdated
Show resolved
Hide resolved
jgiven-html5-report/src/main/java/com/tngtech/jgiven/report/html5/Html5AttachmentGenerator.java
Outdated
Show resolved
Hide resolved
jgiven-html5-report/src/main/java/com/tngtech/jgiven/report/html5/Html5AttachmentGenerator.java
Outdated
Show resolved
Hide resolved
...html5-report/src/test/java/com/tngtech/jgiven/report/html5/Html5AttachmentGeneratorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
l-1squared
previously approved these changes
Aug 13, 2021
jgiven-html5-report/src/main/java/com/tngtech/jgiven/report/html5/Html5AttachmentGenerator.java
Outdated
Show resolved
Hide resolved
...html5-report/src/test/java/com/tngtech/jgiven/report/html5/Html5AttachmentGeneratorTest.java
Outdated
Show resolved
Hide resolved
jgiven-html5-report/src/main/java/com/tngtech/jgiven/report/html5/Html5AttachmentGenerator.java
Show resolved
Hide resolved
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
corbym
previously approved these changes
Aug 13, 2021
|
Not that I count 😂 |
fudler
reviewed
Aug 16, 2021
jgiven-html5-report/src/main/java/com/tngtech/jgiven/report/html5/Html5AttachmentGenerator.java
Outdated
Show resolved
Hide resolved
jgiven-html5-report/src/main/java/com/tngtech/jgiven/report/html5/Html5AttachmentGenerator.java
Show resolved
Hide resolved
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
fudler
approved these changes
Aug 17, 2021
|
Just a follow up question: when will this be released? Thanks M |
|
Hi @corbym, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #703