Add support for spock2 #784
Conversation
jsalinaspolo
force-pushed
the
spock-2
branch
6 times, most recently
from
7c17aec
to
72f64de
Compare
Signed-off-by: Javier Salinas <jsalinaspolo@gmail.com>
jsalinaspolo
force-pushed
the
spock-2
branch
from
72f64de
to
6856c6e
Compare
| @@ -74,7 +73,7 @@ subprojects { | |||
| jacocoVersion = '0.8.5' | |||
| quickcheckVersion = '0.6' | |||
| hsqldbVersion = '2.3.2' | |||
| byteBuddyVersion = '1.10.2' | |||
| byteBuddyVersion = '1.12.3' | |||
jgiven-spock2/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| /target | |||
There was a problem hiding this comment.
weird... Isn't there a global gitignore that should exclude that directory?
There was a problem hiding this comment.
copy/paste from spock1 module, that was copied from jgiven-junit 😆
Fixing it
| new Scenario<GIVEN, WHEN, THEN>(givenClass, whenClass, thenClass) | ||
| } | ||
|
|
||
| private <T> Class<T> addDoNotInterceptToMetaClass(Class<T> clazz) { |
There was a problem hiding this comment.
I can understand why this exists, but do you happen to know, why it wasn't needed in the spock1 Package?
There was a problem hiding this comment.
I think it is related with Groovy 3 vs Groovy 2
The Generated class of MetaClass comes as a method to intercept
| } |
There was a problem hiding this comment.
Thanks for polishing :)
| import spock.lang.Shared | ||
| import spock.lang.Specification | ||
|
|
||
| class ScenarioSpec<GIVEN, WHEN, THEN> extends Specification { |
There was a problem hiding this comment.
Maybe add javadoc and an @since annotation here aswell? After all, the entire module will only be available from 1.2.0 onwards
|
|
||
| implementation "org.codehaus.groovy:groovy:$groovy_version" | ||
| implementation "org.spockframework:spock-core:$spock2_version" | ||
| implementation "org.spockframework:spock-junit4:$spock2_version" |
There was a problem hiding this comment.
Question: wouldn't it make sense to try to align the spock2 package with JUnit 5 directly? If I recall correctly Spock2 is JUnit5 based and upgrading the published jgiven package later should be significantly harder.
There was a problem hiding this comment.
Spock2 uses JUnit Platform used in JUnit5, but it does not use JUnit5. Therefore can not use the Junit5 Extensions.
At the end, it is an implementation detail for the user of the library. The user will not see that internally we are using JUnit4 Rules, but we can migrate to native Spock at some point in the future.
Using Spock2 allows users of the library to migrate to JDK17
Signed-off-by: Javier Salinas <jsalinaspolo@gmail.com>
Signed-off-by: Javier Salinas <jsalinaspolo@gmail.com>
jsalinaspolo
force-pushed
the
spock-2
branch
from
379c0f7
to
0939ea9
Compare
No description provided.