Bugfix/issue 821 ignore errors during annotation scan #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
The test logger uses a non threadsafe static list to record log events that appear on any class to which it is attached. A static field is not required for the purposes of this class, which is recording log events during a single run of a single test class. In fact it is detrimental, for the register could contain lons from parallel runs. Therefore the static field was made an instance field Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
In commit fd97825 a catch clause was removed that omitted errors from the annotation evaluator that were from reading annotations that simply don't have a value method, because they were never meant to be tags. This results in JGiven printing lots of errors for every annation that could possbliy exist on a test class or method. Therefore the catch clause was reintroduced an a test for its existence was added. Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
fudler
approved these changes
Feb 1, 2022
l-1squared
deleted the
bugfix/Issue-821-ignore-errors-during-annotation-scan
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.