Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bootstrap_css load in forced photometry html #761

Conversation

jchate6
Copy link
Contributor

@jchate6 jchate6 commented Nov 29, 2023

I don't have a ton of experience with the forced photometry stuff.
I just want to make sure this doesn't break anything major before implementing it.

This removes the bootstrap_css so it doesn't overwrite the regular CSS from base.html.

I also snuck in a message about how to configure forced photometry in case none were currently available.

Remove all the css/script importing because that was for a bootstrap-modal module I didn't end up using
Copy link
Contributor

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I removed the rest of the css/script stuff since I don't think its necessary. I think I was adding that back when I was trying to get the bootstrap-modal plugin working but I abandoned that idea and didn't remove all the code.

@jchate6 jchate6 merged commit 02a824c into dev Nov 29, 2023
21 checks passed
@jchate6 jchate6 deleted the 760-custom-css-is-being-overwritten-by-bootstrap-for-the-target-detail-page branch November 29, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom CSS is being overwritten by bootstrap for the target detail page.
2 participants