Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the rfscore field with rf_snia_vs_nonia #27

Merged

Conversation

FusRoman
Copy link
Contributor

@FusRoman FusRoman commented Feb 21, 2022

Modification of the deprecated field.
close #26

@JulienPeloton
Copy link
Collaborator

Thanks @FusRoman for the modification -- there is another place that contains the old naming:

COLUMNS = 'i:candid,d:rfscore,i:ra,i:dec,i:jd,i:magpsf,i:objectId,d:cdsxmatch'

Could you make the change please?

@FusRoman
Copy link
Contributor Author

Thanks @FusRoman for the modification -- there is another place that contains the old naming:

COLUMNS = 'i:candid,d:rfscore,i:ra,i:dec,i:jd,i:magpsf,i:objectId,d:cdsxmatch'

Could you make the change please?

Hi @JulienPeloton, i have done the modification, sorry for the omission.

@JulienPeloton
Copy link
Collaborator

Failing tests are unrelated to the modifications here -- I am merging then!

@JulienPeloton JulienPeloton merged commit 115f61c into TOMToolkit:main Feb 22, 2022
@JulienPeloton JulienPeloton mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError when launching query
2 participants