Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dev deploy logs wip #94

Merged
merged 4 commits into from
Dec 20, 2022
Merged

feat: dev deploy logs wip #94

merged 4 commits into from
Dec 20, 2022

Conversation

jpsavy
Copy link
Contributor

@jpsavy jpsavy commented Dec 15, 2022

Which issue(s) this PR fixes

Fixes #54

Additional comments

Agreements

@jpsavy jpsavy linked an issue Dec 15, 2022 that may be closed by this pull request
@jpsavy jpsavy marked this pull request as ready for review December 19, 2022 19:01
Copy link
Member

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

IMO I find it weird having operation in desc order.

I believe the last operation should be at the end, it's more natural.

@PaulFarault
Copy link
Contributor

I believe the last operation should be at the end, it's more natural.

It seems more practical to have them in the other way when, for example, monitoring logs from an ongoing deployment.

We can invert the order for now and create an issue to add an "order" button later.

@jpsavy
Copy link
Contributor Author

jpsavy commented Dec 20, 2022

The last operation is now at the end.

@jpsavy
Copy link
Contributor Author

jpsavy commented Dec 20, 2022

The "order" button will be add in the issue #104

@jpsavy jpsavy merged commit 62f4317 into master Dec 20, 2022
@jpsavy jpsavy deleted the 54-past-deployment-logs branch December 20, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Past deployment logs
3 participants