Escape username and database name in PostgreSQL procedures #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid database names and usernames might have upper case characters. However, if they are passed without proper escaping PostgreSQL will end up referencing the name using wrong case and later the procedure will error on not finding the correct username or database name. Fix this by using double quotes when passing usernames or database names. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
|
I have tested the changes for TPROC-C & H for build and test and all work fine. Recommend to accept. |
|
Merging Pull Request as voted on by TPC-OSS subcommittee on April 20, 2022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valid database names and usernames might have upper case characters. However, if
they are passed without proper escaping PostgreSQL will end up referencing the
name using wrong case and later the procedure will error on not finding the
correct username or database name.
Fix this by using double quotes when passing usernames or database names.
All new code of the whole pull request, including one or several files that are
either new files or modified ones, are contributed under the BSD-new license. I
am contributing on behalf of my employer Amazon Web Services, Inc.