-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for TPROC-H calculates o_totalprice incorrectly #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiere-msft
approved these changes
Oct 2, 2023
JoshInnis
pushed a commit
to JoshInnis/HammerDB
that referenced
this pull request
Oct 2, 2023
Update the total price logic for BCP to be in line with the PR TPC-Council#610.
abondvt89
approved these changes
Oct 3, 2023
Merging after reviews and approval of the three members of the code maintenance team. |
sm-shaw
added a commit
that referenced
this pull request
Oct 3, 2023
* Implement BCP Option for MSSQLS TPCH Load Allow users to use the BCP option to load data for TPCH data. The option is enabled by default, becuase BCP will work for both SQL and Windows Authentication. * Add mk_time_bcp to export list Added mk_time_bcp in export list for tpchcommon to be used in mssqls' TPCH load process when BCP is enabled * Update total price for BCP Load of TPCH Update the total price logic for BCP to be in line with the PR #610. * Add XML variable and updates to TPCH BCP * Fix XML spacing --------- Co-authored-by: Josh Innis (Warner Marketing Incorporated) <v-joshinnis@microsoft.com> Co-authored-by: Steve Shaw <smshaw@users.sourceforge.net> Co-authored-by: Steve Shaw <38044085+sm-shaw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes o_totalprice calculation for all databases for TPROC-H schema load.
Also does the same for refresh function, which is defined as follows:
However, o_totalprice is calculated from the sum of the rows in LINEITEM and therefore we need to insert it after LINEITEM otherwise o_totalprice is 0 (current behaviour) This in turn causes the issue that we have a foreign key on LINEITEM L_ORDERKEY referencing ORDERS O_ORDERKEY, so we cannot insert in ORDERS before as we don't know o_totalprice and cannot insert after as it violates the FK.
Therefore, have added deferrable constraints for Oracle and PostgreSQL and temporary disabling of FK checks for SQL Server, MySQL/MariaDB and Db2 so that the refresh function will work by inserting into LINEITEM first.