Take advantage of Node's built-in streaming backpressure #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new client certainly has backpressure, it uses the mdn streams interface and pauses everything after a member is found and resumes when a new member is expected. If you need any other features in the new client that prevents you from changing, please let us know! @erikap @madnificent |
ajuvercr
reviewed
Mar 25, 2024
Comment on lines
+292
to
+298
| * TODO: There is an issue with the TREE metadata extractor | ||
| * changing the casing of the LDES IRI e.g.: | ||
| * https://semiceu.github.io/LinkedDataEventStreams/example.ttl#eventstream | ||
| * gets changed to: | ||
| * https://semiceu.github.io/linkeddataeventstreams/example.ttl#eventstream | ||
| * which prevents tree:views to get booked | ||
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an attempt to take advantage of Node's built-in backpressure in streams (i.e. buffering in case of a slower consumer) instead of trying to manage it ourselves. It also includes an exponential backoff mechanism to retry failing requests.
This PR should not be merged as such. We've removed some code (like for example the
pausedflag) which may be considered a breaking change (although it looks like an internal to us) and didn't extensively test all different kinds of representations. Given that a new implementation is being worked on in https://github.com/TREEcg/ldes-client, it does not seem appropriate to us to further clean up and elaborate on this PR, but we wanted to indicate what our issues have been with this client so that they can possibly be taken into account in the new implementation.Co-author: @madnifcent