Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radarr): removed CiNEPHiLES from Remux Tier #1523

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Aug 25, 2023

Pull Request

Purpose

Removed RlsGrp CiNEPHiLES from Remux Tier to prevent download loops.

This RlsGrp often sources alternative audio tracks, and adds these to releases alongside modern multichannel audio. Users have reported download loops as the audio format referred to in the release name does not always match the audio format in the filename. TRaSH Guides relies on automation provided by using different scores for different audio formats, so inconsistencies in naming will lead to download loops.

Radarr only probes the first audio track of any file, and cannot read nfo files. Discovery of multiple audio tracks would currently require scraping the tracker or indexer, which is not permitted. If both the release name and the filename do not contain the audio format used for the first audio track in the file, then download loops will result.

This issue is resolvable by the implementation of consistent release and file naming with regards to audio formats.

Approach

Removed RlsGrp CiNEPHiLES from Remux Tier and added them to the LQ

Open Questions and Pre-Merge TODOs

Requirements

@github-actions github-actions bot added Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats labels Aug 25, 2023
Copy link
Contributor

@bakerboy448 bakerboy448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; marking do not merge pending discussions with CiNEPHiLES

@bakerboy448 bakerboy448 added the Do Not Merge Do Not Merge label Aug 25, 2023
@TRaSH-
Copy link
Contributor Author

TRaSH- commented Aug 27, 2023

After reporting this issue to a CiNEPHiLES member, they said that another member made the mistake by using the wrong release name that didn't match the actual correct filename.

example:
filename: movie.year.2160p Remux DoVi HDR10+ HEVC FLAC 2.0-CiNEPHiLES
releasename: movie.year.2160p Remux DoVi HDR10+ HEVC TrueHD 7.1-CiNEPHiLES

Why is this wrong?:
The release name+filename should hold the info of the first audio track

Solution:

the process should be done that is matching filename to release name
once the guys get back they will rename the "release name" to match the filename

Being this isn't the first occurrence of mismatched naming. We have decided as Team that if we get further reports of wrong release/file names we will draw a line and move them (CINEPHILES) without any further reports to the LQ

@TRaSH- TRaSH- marked this pull request as draft August 27, 2023 08:29
@TRaSH- TRaSH- self-assigned this Oct 15, 2023
@bakerboy448 bakerboy448 added Type: Enhancement Feature Request or Improvement of suboptimal status quo Status: Maybe One Day No plans at this time. Tagged for future considerations. labels Mar 3, 2024
@FonduemangVI
Copy link
Contributor

@TRaSH- I think we can close this one off for now?

@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats Do Not Merge Do Not Merge Status: Maybe One Day No plans at this time. Tagged for future considerations. Type: Enhancement Feature Request or Improvement of suboptimal status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants