Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Rework Radio #1095

Closed
TimGoll opened this issue Oct 24, 2023 · 5 comments
Closed

[Feature] Rework Radio #1095

TimGoll opened this issue Oct 24, 2023 · 5 comments

Comments

@TimGoll
Copy link
Member

TimGoll commented Oct 24, 2023

  • Remove the radio UI from the shop
  • add a custom menu with a custom keybind
  • the keybind should be listed in the equipment section if a player owns a radio

@EntranceJew had a few feature ideas that could be added here as well

@EntranceJew
Copy link
Contributor

Yes, the major thing being:

  • items become able to register their main functionality sound effects, so that other weapons (such as the radio) can intentionally invoke a noise that is the same as it
  • concommand ttt_radio plays using the format ttt_radio c4beep [n] instead of using the arbitrary entity ID (a netmessage workaround hack atm), where [n] is a radio in the player or team's control, but defaults to their first owned one

@TimGoll
Copy link
Member Author

TimGoll commented Oct 24, 2023

RE point two: Should we add a keybind for this? Something like "play last sound"? Then we can remove the command that is annoying

@TimGoll TimGoll added type/enhancement Enhancement or simple change to existing functionality type/feature New functionality labels Oct 24, 2023
@EntranceJew
Copy link
Contributor

repeat last sound bind would be a worthwhile, but the ability to quickly tell a "story" with radio commands IMO such as "footsteps => death scream" is still the priority.
on a custom menu, if it were a radial then "repeat last command" would probably be the center option.
image
horrible diagram warranted

there should still be the annoying concommand, to call the sounds individually, just change the structure of it, since it's being abused, and people with other radial bind menus might like to manually remap them the way I do with the radio callouts

Copy link

stale bot commented Feb 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 11, 2024
@TimGoll
Copy link
Member Author

TimGoll commented Mar 9, 2024

This was done in #1437

We might add a radial menu in the future, but the main task of this issue is done

@TimGoll TimGoll closed this as completed Mar 9, 2024
@Histalek Histalek removed type/enhancement Enhancement or simple change to existing functionality type/feature New functionality labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants