-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio: Create new UI for remote useable radio #1437
Conversation
We should add some sort of indication that the radio supports this kind of stuff, right now no one can figure that out I think |
bb659f3
to
c71a1cb
Compare
7289aac
to
ee1dd37
Compare
f77b943
to
1f90813
Compare
c3222f2
to
1354356
Compare
1354356
to
d8476d7
Compare
I added a general name for the translation string, because I could imagine to use this generally for all entities Use / UseOverride / ClientUse and RemoteUse. Normally UI descriptions should be kept shortm if you want more information it should be standing somewhere else. So I dont want to add "this {radio_name}" or "remotely" as this is kinda self explaining if you just try to press E. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Could you please put the keybind in the subtitle instead of a "random" description line? Right now it gets kind of lost and it is also not in-line with the other targetID implementations: https://github.com/TTT-2/TTT2/blob/master/lua/ttt2/libraries/targetid.lua#L621-L628 Edit: Ah well, there is no subtitle for marker vision. I can add it in a PR this week and then you can use it. Would that be ok? |
I get what you mean, but you could also improve it yourself when its implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll rework the tooltip today or tomorrow then! Please merge the two open suggestions before merging the PR though, thanks.
Co-authored-by: Tim Goll <github@timgoll.de>
Co-authored-by: Histalek <16392835+Histalek@users.noreply.github.com>
After testing #1437 I notices that it feels really weird to not have any kind of feedback when interacting with entities. When picking up entities, there already is a sound, but not when opening UIs. Therefore I added `sound.ConditionalPlay` that plays a sound if the sound type is enabled in the settings. I also extended this to body search and UI buttons. See this demo video: https://www.youtube.com/watch?v=c6ixkuFSYfw Note: I also pulled in the changes from #1351 and added them to the same system. They are disabled by default. Menu to disable sounds by type: ![image](https://github.com/TTT-2/TTT2/assets/13639408/fe57417b-f55f-42cd-952d-c632b4aaab1e) --------- Co-authored-by: EntranceJew <EntranceJew@gmail.com>
This is a followup to #1437 where this was initially missed. I've also removed the duplicated `SWEP.EquipMenuData`.
This is a followup to #1437 where this was initially missed. I've also removed the duplicated `SWEP.EquipMenuData`.
This is a followup to #1437 where this was initially missed. I've also removed the duplicated `SWEP.EquipMenuData`.
This is a followup to #1437 where this was initially missed. I've also removed the duplicated `SWEP.EquipMenuData`.
This is a followup to #1437 where this was initially missed. I've also removed the duplicated `SWEP.EquipMenuData`.
Before this you had to navigate to the shop tabs to use it, which is really unintuitive and currently blocks our idea to do a new shop.
![grafik](https://private-user-images.githubusercontent.com/72046466/307606558-cf56c6e4-3d36-4e77-9ea8-94eceba39173.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODI4NzQsIm5iZiI6MTczOTM4MjU3NCwicGF0aCI6Ii83MjA0NjQ2Ni8zMDc2MDY1NTgtY2Y1NmM2ZTQtM2QzNi00ZTc3LTllYTgtOTRlY2ViYTM5MTczLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE3NDkzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0ZTllMmMyZTU3MmNkMjI5NWM2OTQ0MDlmODY1OTJjMzc4ZmRiNTFkYzc4NDk3ZjcxOGQ2Y2NlYTAwNDhkMTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.GKSWAgXs2PjSWyT-nQFXvZOzZmWrC1uSCS83nqb8v6Q)
Now you can use the 'Use'-Key from any distance on the focussed radio marker
![grafik](https://private-user-images.githubusercontent.com/72046466/309918041-7c4d6c30-d48b-40c1-b799-934fd09d7aad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODI4NzQsIm5iZiI6MTczOTM4MjU3NCwicGF0aCI6Ii83MjA0NjQ2Ni8zMDk5MTgwNDEtN2M0ZDZjMzAtZDQ4Yi00MGMxLWI3OTktOTM0ZmQwOWQ3YWFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE3NDkzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1NWEzMzA5YjdlZjhmZDgyNjUzMzRiNjQ0ZTQzYTY2ZGJiNWY0ZmM2NGFmYzA1M2RiNjhlNzg5OGUwZDI4NjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.1_2Js5cAdzCG7RiA_hbZOIGBdDiC9vyEpV6Hmk3z14I)
![grafik](https://private-user-images.githubusercontent.com/72046466/307606316-a9fa7cd5-e929-4878-9e54-3f63aba65737.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODI4NzQsIm5iZiI6MTczOTM4MjU3NCwicGF0aCI6Ii83MjA0NjQ2Ni8zMDc2MDYzMTYtYTlmYTdjZDUtZTkyOS00ODc4LTllNTQtM2Y2M2FiYTY1NzM3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE3NDkzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUzODc2MjY4NTlkZTIzYTM3MWRjZjhjZTBkMGVkNTE3MDAzZWE3MTg1YTllMzI3YTM5MmU4NmNlZmU3OWM2N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yM448KIGVJAnNIQKkBtMt0tUMwkwWENM1iPEf9kVUY4)
and get the following new UI, which triggers the sounds in the same way as before
This will be waiting for the approval of the remote trigger feature in #1436