Entity Base: Add remote triggerable #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGoll
reviewed
Feb 25, 2024
|
Overall I really like this feature, I'm not so sure on its implementation though |
ZenBre4ker
commented
Feb 27, 2024
There was a problem hiding this comment.
I guess I'm gonna put this to draft again. As it was mainly a quick way to get remote use to work. But I will try to work on a proper implementation in GM:KeyRelease instead and combine it with weapon pickup and bodysearch to be client-authorative and just checked by the server if it is generally possible.
ZenBre4ker
added
the
status/waiting
|
This shall be based on #1447 instead of this unrelated hook. |
ZenBre4ker
force-pushed
the
remote_triggerable
branch
from
bb659f3 to
c71a1cb
Compare
|
Updated and waiting for #1447 |
ZenBre4ker
force-pushed
the
remote_triggerable
branch
from
9f80588 to
f77b943
Compare
ZenBre4ker
force-pushed
the
remote_triggerable
branch
from
f77b943 to
1f90813
Compare
ZenBre4ker
removed
the
status/waiting
|
Next one is directly ready 😆 |
TimGoll
reviewed
Mar 3, 2024
TimGoll
approved these changes
Mar 4, 2024
ZenBre4ker
added a commit
that referenced
this pull request
Mar 6, 2024
Before this you had to navigate to the shop tabs to use it, which is really unintuitive and currently blocks our idea to do a new shop.  Now you can use the 'Use'-Key from any distance on the focussed radio marker  and get the following new UI, which triggers the sounds in the same way as before  This will be waiting for the approval of the remote trigger feature in #1436 --------- Co-authored-by: Tim Goll <github@timgoll.de> Co-authored-by: Histalek <16392835+Histalek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to gather the focussed markers and enables a clientside remote trigger to placeable entities.
Shall further enable the removal of radio tabs in shop.
Hopefully can be used for a radar as well, if we make it placeable for example.