Sounds: Added multiple UI sounds #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGoll
added
the
type/enhancement
Histalek
requested changes
Mar 7, 2024
|
all things should be done @Histalek |
Histalek
approved these changes
Mar 7, 2024
saibotk
requested changes
Mar 7, 2024
saibotk
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing #1437 I notices that it feels really weird to not have any kind of feedback when interacting with entities. When picking up entities, there already is a sound, but not when opening UIs. Therefore I added
sound.ConditionalPlaythat plays a sound if the sound type is enabled in the settings.I also extended this to body search and UI buttons.
See this demo video: https://www.youtube.com/watch?v=c6ixkuFSYfw
Note: I also pulled in the changes from #1351 and added them to the same system. They are disabled by default.
Menu to disable sounds by type:
