Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Breaking Gamemode #1676

Open
TimGoll opened this issue Nov 1, 2024 · 4 comments · May be fixed by #1686
Open

Map Breaking Gamemode #1676

TimGoll opened this issue Nov 1, 2024 · 4 comments · May be fixed by #1686
Assignees
Milestone

Comments

@TimGoll
Copy link
Member

TimGoll commented Nov 1, 2024

TTT2 v0.14.0

Aparantly this map breaks the whole gamemode: https://steamcommunity.com/sharedfiles/filedetails/?id=2991532471

Image

@TimGoll TimGoll added type/bug Something isn't working and removed type/bug Something isn't working labels Nov 1, 2024
@TimGoll TimGoll added this to the v0.14.1b milestone Nov 1, 2024
@NickCloudAT
Copy link
Contributor

Image
The map has this file (b-draw_lib.lua) which seems to overwrite some draw functions that TTT2 uses.

@TimGoll
Copy link
Member Author

TimGoll commented Nov 2, 2024

Hmm, good to know then. I'm not sure if there is a good way to fix that though. We could make our functions a bit more resilient so that they do not error out but use a default color or so

@Histalek
Copy link
Member

Histalek commented Nov 6, 2024

Hmm, good to know then. I'm not sure if there is a good way to fix that though. We could make our functions a bit more resilient so that they do not error out but use a default color or so

Essentially this is a file conflict and solving this issue on any other level is nothing more than a band-aid

This breakage is unfortunate and probably unintentionally caused by fb43db1 and/or a3057d3

The changes made in those commits are not self-contained and we cannot simply move them to another file

If we want to solve this ourselves we would need to move every function that was remotely touched in the above commits into a new file/lib and ensure that those use another name and revert/remove the b-draw_lib.lua file

Given that our file doesn't really look like the original b-draw_lib.lua [1] anymore we might be fine with pushing the functions in that file into our draw extension (half of the functions are already namespaced to draw. anyway so we might as well)

[1] https://github.com/bull29/b_draw-lib/blob/master/lua/autorun/client/b-draw_lib.lua

@TimGoll
Copy link
Member Author

TimGoll commented Nov 7, 2024

I support moving them to a new file. Renaming them is probably also fine as I don't think any addon (besides our killer info addon) uses these functions anyway

@Histalek Histalek self-assigned this Nov 15, 2024
Histalek added a commit that referenced this issue Nov 27, 2024
This fixes #1676 by removing the file conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants