Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items that cant be bought due to minimum player amount being set below current playercount show up in Random Shop. #1679

Open
MrXonte opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1683
Assignees
Labels
status/confirmed Validated by a project member

Comments

@MrXonte
Copy link
Contributor

MrXonte commented Nov 25, 2024

Your version of TTT2 (mandatory)

Workshop version from Steam (v0.14.0b)

Describe the bug (mandatory)

Items with a minimum player number set show up in random shops even if the player number is too low for them to be buyable, taking away options.

To reproduce

Steps to reproduce the behaviour:

  1. Set items to a minimum player number
  2. Enable random shop
  3. play with less players than that number
  4. Have "wasted" shop slots

Expected behaviour

Disabled items (which I count items that cant be used due to player count) should not be in the random shop.

Context (please provide as much as you can)

clean TTT2

@saibotk saibotk added the type/bug Something isn't working label Nov 26, 2024
@Histalek Histalek removed the type/bug Something isn't working label Nov 26, 2024
@Histalek Histalek self-assigned this Nov 26, 2024
Histalek added a commit that referenced this issue Nov 27, 2024
This fixes #1679, very well aware that other limitations (team/global
limited) are still not respected and might still show up.
Histalek added a commit that referenced this issue Nov 27, 2024
This fixes #1679, very well aware that other limitations (team/global
limited) are still not respected and might still show up.
Histalek added a commit that referenced this issue Nov 27, 2024
This fixes #1679, very well aware that other limitations (team/global
limited) are still not respected and might still show up.
Histalek added a commit that referenced this issue Nov 27, 2024
This fixes #1679, very well aware that other limitations (team/global
limited) are still not respected and might still show up.
@MrXonte
Copy link
Contributor Author

MrXonte commented Dec 3, 2024

I also noticed a sub-issue to this yesterday. Currently, items can unlock when people join the server. This means that mid-round, a locked item can become available since the check is not based on players who played this round but rather on all players currently connected to the server.
If the items don't show up in random shops, this should mostly avoid the issue, although there is still the possibility of re-rolling a shop mid-game and suddenly having such an item. If I understand the current logic correctly, this also means that an item can become unavailable again if people disconnect (even if they were just spectators).

@Histalek Histalek added the status/confirmed Validated by a project member label Dec 4, 2024
Histalek added a commit that referenced this issue Dec 10, 2024
This fixes #1679, very well aware that other limitations (team/global
limited) are still not respected and might still show up.
Histalek added a commit that referenced this issue Dec 18, 2024
This fixes #1679, very well aware that other limitations (team/global
limited) are still not respected and might still show up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/confirmed Validated by a project member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants