AddonChecker: added base checking #1425
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that e.g. TFA weapons ( see #1432 ) do not use Maybe we could gate this weaponbase scanning behind a flag and not run it by default? Or split this out into another function which can be triggered by a different concommand? If this is split and not run by default i would be fine with merging this. Giving serverowners a tool to discover these kinds of possibly problematic weapons definitely has value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a draft as I have to test how useful this actually is. But this is what I envisioned: Print a warning in the addon checker if an addon uses the wrong base. Sadly I think there is no way to detect the addon where this file came from.