Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectators no longer visible in thermalvision #1666

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

MrXonte
Copy link
Contributor

@MrXonte MrXonte commented Oct 16, 2024

A check was added to prevent spectators from being displayed with thermal vision. This is relevant in cases where players are highlighted by TV and then killed, as they are not automatically removed from the entity list. Also prevents SpecDM players from being seen.

@MrXonte MrXonte requested a review from TimGoll October 16, 2024 14:38
@TimGoll
Copy link
Member

TimGoll commented Oct 16, 2024

Looks good to me now. We probably have to do the same for the outline and marks module.

May I ask which weapon/addon you are using that has thermal vision?

@TimGoll TimGoll merged commit 35450d5 into TTT-2:master Oct 16, 2024
4 checks passed
@MrXonte
Copy link
Contributor Author

MrXonte commented Oct 16, 2024

I was using a custom weapon that I haven't published to the workshop yet, waiting for the thermalvision library update to be public. Basicly just a sniper that adds all alive players to thermalvision when scoping in

@MrXonte
Copy link
Contributor Author

MrXonte commented Nov 12, 2024

@TimGoll, since you asked about the addon, I uploaded it today: Thermal Rifle.

@Histalek Histalek added this to the v0.14.1b milestone Nov 15, 2024
Histalek pushed a commit to WardenPotato/TTT2 that referenced this pull request Jan 31, 2025
A check was added to prevent spectators from being displayed with
thermal vision. This is relevant in cases where players are highlighted
by TV and then killed, as they are not automatically removed from the
entity list. Also prevents SpecDM players from being seen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants