[bspc.c] Change directory variables to have static storage #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
force-pushed
the
static
branch
2 times, most recently
from
071c63f to
24b5b24
Compare
|
MAX_PATH is a hard limit on Windows (set at 260). But I think you are mostly interested in changing that for Linux/MacOS X. I searched through the code and it doesn't seem to affect on disk formats, so I went ahead and cleaned things up. Removed _MAX_PATH usage, made everything on MAX_PATH, and set to 8192 on != _WIN32. I'm going to check that in directly but please have a look at test that bspc is still fine .. |
|
Thank you very much - I'll take a look! |
tkoeppe
force-pushed
the
static
branch
3 times, most recently
from
9024417 to
e272aef
Compare
quite large for automatic storage.
tkoeppe
changed the title
|
Thanks a lot for your change, that solves most of the problem. I repurposed this PR to make the directory arrays static, since they're quite big and don't need to be on the stack. (Fortunately there's no question of reentrancy in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TTimo: Hi - I'm sending you a bunch of PRs, mostly fixes of bugs reported by compiler warnings. This PR is a bit different; it increases the limit on path lengths. If you don't care for this, just close the PR.