Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wibo critical path cosmetics #127

Open
wants to merge 70 commits into
base: master
Choose a base branch
from

Conversation

GerbenJdeBoer
Copy link
Contributor

Please have a look at this example: it combines occupancy analysis with critical path.

@Pietervanhalem Pietervanhalem self-requested a review March 2, 2023 12:14
@Pietervanhalem
Copy link
Contributor

image

This basic activity is optional. Its not wrong or anything but it does not nessescary make sense to have a basic activity there. So you might get better figures if you remove this.

@Pietervanhalem
Copy link
Contributor

I dont see issues with the container reservations Looks good!

@Pietervanhalem
Copy link
Contributor

To me the occupancy analysis also seems good! Nice job:

I did:

results = []
for i in range(len(barge_names)):
    results.append(run(i+1,total_amount)) # at least 1 barge
    vessels = results[i]['vessels']
    activities = results[i]['activities']
    cutter = vessels[cutter_name]
    to_site = results[i][to_site_name]
    from_site = results[i][from_site_name]
    df = occupancy_analysis(vessels, cutter, activities)
    display(df)

so I can see the dataframes as well. Really nice to see that the cutter occupancy goes up but the barge occupancy goes down when you have more barges.

Very nice!

Copy link
Contributor

@Pietervanhalem Pietervanhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 35 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants