Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker geos version #140

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Fix docker geos version #140

merged 4 commits into from
Aug 28, 2023

Conversation

SiggyF
Copy link
Contributor

@SiggyF SiggyF commented Jul 9, 2023

libgeos is installed. IT installed a specific version. This is no longer available after upgrade of base image.
this change will install latest version of libgeos. This should match with the python version.

@SiggyF SiggyF requested a review from arashsepehri July 9, 2023 12:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SiggyF SiggyF requested a review from Pietervanhalem July 9, 2023 13:04
Copy link
Contributor

@Pietervanhalem Pietervanhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the tests fail?

@GerbenJdeBoer
Copy link
Contributor

GerbenJdeBoer commented Aug 14, 2023

@SiggyF
Copy link
Contributor Author

SiggyF commented Aug 18, 2023

This branch solves a problem with geos, but at the same time azure decided that we are over our limit of available branches.
We currently only have 3 active branches. So my first approach is to increase the number of allowed branches.
After that I'll try to follow this approach. The issue there is that you have to program yourself how to cleanup old branches. The implementation is in javascript / npm, so I would first need to adapt that or add npm (too much tech for 1 repo).

@SiggyF
Copy link
Contributor Author

SiggyF commented Aug 18, 2023

According to an open issue at Azure this is a hard limit. They are working on it, though. I'll manual delete them and consider to script the deletion, but that's also a bit error prone.

I can also switch to netlify, which supports more branches. But then we have yet another subscription (already have azure, sonarcloud, circleci).

@SiggyF
Copy link
Contributor Author

SiggyF commented Aug 18, 2023

I have disabled building the book on PR for now. Then we should not run into the issue. For now, we have to test changes to the book locally.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-140.westeurope.1.azurestaticapps.net

@SiggyF SiggyF requested a review from GerbenJdeBoer August 18, 2023 09:47
@GerbenJdeBoer
Copy link
Contributor

ok

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SiggyF SiggyF merged commit d81358b into master Aug 28, 2023
@SiggyF SiggyF deleted the fix/docker-geos branch August 31, 2023 08:52
@SiggyF SiggyF restored the fix/docker-geos branch August 31, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants