Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced / Energy #41

Open
2 of 3 tasks
SiggyF opened this issue Apr 20, 2022 · 6 comments
Open
2 of 3 tasks

Advanced / Energy #41

SiggyF opened this issue Apr 20, 2022 · 6 comments
Assignees
@mvgijn

Comments

@SiggyF
Copy link
Contributor

SiggyF commented Apr 20, 2022 •
edited
Loading

  • Create new toc for Advanced simulations
  • Pick notebooks per toc item
  • Improve notebooks
@SiggyF
Copy link
Contributor Author

SiggyF commented May 11, 2022

Energy, fuel use and emissions are together in a notebook (only schematic). This is fine for now as they are computed together.

@SiggyF
Copy link
Contributor Author

SiggyF commented May 11, 2022

Example 14, 15, 16 are a bit old (and less clean). They do provide input on using real world data. Let's wait to incorporate real world data for energy until it is more settled.

@SiggyF
Copy link
Contributor Author

SiggyF commented May 11, 2022

From the multiple vessels examples we will keep the vessel from dataset generation.

@SiggyF
Copy link
Contributor Author

SiggyF commented May 11, 2022

Example 12 is very basic. We'll remove that from the TOC.

@SiggyF
Copy link
Contributor Author

SiggyF commented May 11, 2022

For now we'll remove Example 13 (vessel restrictions: class, dimensions). This could make an interesting item in the real-world data section.

mvgijn added a commit that referenced this issue May 11, 2022
@mvgijn
Revise the TOC for advanced simulations
7b3cc17 
Includes change of titles for some notebooks and is described in #41.
mvgijn added a commit that referenced this issue May 11, 2022
@mvgijn
update title notebook example 11 #41
c36864f
mvgijn added a commit that referenced this issue May 11, 2022
@mvgijn
Picked the right notebooks #41
670ab75 
Also applied the same lay-out/ formatting for all 4 notebooks as described by Mark.
@mvgijn
Copy link
Contributor

mvgijn commented May 12, 2022

Made some improvements on notebook example 10 and example 11. Also ran into some errors in the online book. Have sent these to fedor via mail and will discuss the solution.

mvgijn added a commit that referenced this issue May 12, 2022
@mvgijn
Made some improvements #41
e5aa833 
Added some extra explanatory text to 'create graph' from example 10.
SiggyF pushed a commit that referenced this issue May 16, 2022
Merge branch 'feature/notebooks-integration' of github.com:TUDelft-CI…
c83cd18 
…TG/OpenTNSim into feature/notebooks-integration

* 'feature/notebooks-integration' of github.com:TUDelft-CITG/OpenTNSim:
  Made some improvements #41
  Picked the right notebooks #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvgijn mvgijn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SiggyF @mvgijn