SwiftUi redesign menu view in map

[Philipp000]

Issue

I think the implementation on how to access a menu in the swift-ui map is currently not very intuitive, with the small toolbar on the top.

Here I implemented a behavior which is more similar to the one used in Apple "Where is?" app.
Therefore, I completely remove the toolbar.
Further actions could be implemented directly into the panel.

Additionally, I fixed a few issues regarding the dark mode and the menu view.

Screenshot

Bildschirmaufnahme.2022-03-08.um.17.23.42.mov

[philippzagar]

@Philipp000 What's the current status of the PR? Can we merge it soon? :)

[Philipp000]

From my side it should be ready to merge. I think @AW-tum wanted to merge it/look it at

[philippzagar]

Really nice PR, thanks! :)
Design-wise it looks basically perfect! I only left some comments regarding the concrete implementation of it, mostly some state-of-the-art techniques.

[philippzagar]

Also, a thing I'm just thinking of now: Maybe we should cut down the ingredients displayed, as it may be confusing and not really comprehensible. @AW-tum what's your take on this?

[Philipp000]

What do you mean about the ingredients?
There was already feedback, and the ingredients are only shown, when the info is clicked (not like in the video anymore).

I have also another small issue, that I wasn't able to fix:
When one selects a canteen and then closes the menu again, the "scroll-position" is not remembered. So, the canteen list is shown from the top again.
However, I have no idea on how to fix this.

[AW-tum]

I just had a look at it in the simulator and I have a few UI remarks

First of all I would stretch the calendar view of the days along the whole screen (right now it seems a little squashed in the center).

Also I would handle the ingredients a little differently. When you open the ingredient subview you get a list of the ingredients as well as their icons. The point of the icons is that we don't have to write out the ingredients every time and therefore save space onscreen.
I would put the icons inside the table cells and remove the possibility to open a subview for ingredients (or show only the icons inside the subview). Instead I would put an "I" button at the top of the card, next to the dismiss-button which gives you a description of all the ingredients and their corresponding icons.

Today (Sunday) obviously no menu can be displayed. For me at least, it hence portrays a blank screen below the calendar-bar. Instead of showing a blank screen I would either show some form of "no menu today"/"cafeteria closed on weekends"/etc. or show the next available menu (in todays case, the one of upcoming Monday). We could signal to the user that it's not actually todays menu by highlighting the menus date with the black circle, setting it apart from a TUM-blue circle to highlight the usage dates day.

[philippzagar]

What do you mean about the ingredients?

There was already feedback, and the ingredients are only shown, when the info is clicked (not like in the video anymore).

I have also another small issue, that I wasn't able to fix:

When one selects a canteen and then closes the menu again, the "scroll-position" is not remembered. So, the canteen list is shown from the top again.

However, I have no idea on how to fix this.

See @AW-tum remarks