Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python.toml #279

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Update Python.toml #279

merged 2 commits into from
Jan 26, 2025

Conversation

Friendly-Banana
Copy link

this changes dependencies from poetry specific format into the general python one
Poetry can only use this format since its version 2.

see https://packaging.python.org/en/latest/guides/writing-pyproject-toml, dev deps, Poetry setup

Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @Friendly-Banana !

Only a single linting issue in the CI needs taking care of.

@Friendly-Banana
Copy link
Author

Will fix that.
Do we need Poetry as a build backend or can I remove that section too? Afaik this is only needed for publishing to PyPi.

@COM8
Copy link
Member

COM8 commented Jan 25, 2025

Yes, you are right. We do not need it since we do not publish it to pip.
As far as I'm aware, you can remove it.

@Friendly-Banana
Copy link
Author

Done, can you run CodeQL/merge? It's apparently disabled for PRs by default

@COM8 COM8 merged commit d6d4b7f into TUM-Dev:master Jan 26, 2025
2 checks passed
@COM8
Copy link
Member

COM8 commented Jan 26, 2025

Merged, thanks!

@Friendly-Banana Friendly-Banana deleted the python.toml branch January 26, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants