Modernize testing frameworks and test fixtures #452

TWiStErRob · 2023-04-06T09:51:54Z

Contributes to #369

Replace buildscript and apply plugin: with plugins { } in tests
Move some repositories blocks to settings.gradle
Reduce subprojects/allprojects usages
Add ability on gradle.file() calls to select what type of merging to do.
Clean up lintOptions, targetSdkVersion, compileSdkVersion DSLs in tests.
Replaced !!.outcome with result.assert*() calls
Migrate kotlin.test to JUnit 5 Jupiter equivalents
Allow relocating temp directory for Gradle Test Kit
Let Metaspace roar free!

…essed.

…h of the Gradle tests.

test/integration/src/test/kotlin/net/twisterrob/gradle/PluginIntegrationTest.kt

test/src/test/kotlin/net/twisterrob/gradle/test/fixtures/mergeGradleScriptsTest.kt

TWiStErRob added 28 commits April 6, 2023 10:26

Replace apply plugin with plugins { }

722762a

Modernise docs/debug and docs/examples projects.

3388c40

Shorten the debug folder names

f620b81

Move repositories to settings in gradle/plugins

39b61d1

Move repositories to settings in fixtures

acac51c

Use generic assignment notation for fixtures

722526f

Use explicit plugin IDs

71423cf

Migrate some buildscript blocks

5dc420a

Remove hack, it works, I just misunderstood it.

5bb48fa

Repurpose hack for something useful.

86a0e76

Make sure all relevant resources of the Gradle test fixtures are proc…

bbc4655

…essed.

Add ability to inject dependencies into the pluginManagement classpat…

842454d

…h of the Gradle tests.

Merge plugins blocks instead of append.

d979ef5

Move repositories to settings in fixtures

650585e

Merge everything!

5f95824

Reduce code duplication in merging

7d6eed2

Fix classpaths of tests and some plugins block problems.

0230287

Fix substitutions

5d9236d

Record TODOs

7e6fb11

Not possible

16f950b

Added a note in Modernize plugin issue

241e967

Clean up line endings in results

abe80ac

Fix all tests

8be7cec

Fix some tests

1ae88e3

It works already

3db22d5

Remove unused buildscript blocks

528a10a

Code review

1558108

Move and rename enum

fba4416

TWiStErRob added this to the v0.16 milestone Apr 6, 2023

TWiStErRob enabled auto-merge (squash) April 6, 2023 09:54

TWiStErRob added 2 commits April 6, 2023 11:19

Remove unnecessary plugins

acd51a3

Replace targetSdkVersion and compileSdkVersion.

208a4f0

TWiStErRob mentioned this pull request Apr 6, 2023

Modernize plugin #369

Closed

18 tasks

TWiStErRob added 9 commits April 6, 2023 11:56

Add support for imports

d6d572b

Fix #437 (comment)

8bf900c

Fix failing test

3fa411c

Replace !!.outcome with .assertX

1504e27

Replace lintOptions with lint

d4ac3f0

Increase timeout

f28174b

Remove kotlin-test dependency

5b48002

Replace kotlin.test.* with their Jupiter equivalents.

6d8c81e

Allow relocating temp directory for Gradle Test Kit

fd88d72

TWiStErRob changed the title ~~Replace buildscript and apply plugin: with plugins { } in tests~~ Modernize testing frameworks and test fixtures Apr 6, 2023

Show test failure origin method on CI

5b18d56

github-advanced-security bot found potential problems Apr 6, 2023

View reviewed changes

test/integration/src/test/kotlin/net/twisterrob/gradle/PluginIntegrationTest.kt Fixed Show fixed Hide fixed

test/integration/src/test/kotlin/net/twisterrob/gradle/PluginIntegrationTest.kt Fixed Show fixed Hide fixed

Make tests pass on all AGP versions

17357ea

TWiStErRob force-pushed the plugins branch from 9449279 to 17357ea Compare April 6, 2023 17:03

TWiStErRob disabled auto-merge April 6, 2023 21:27

Hack memory 2

c7ef3eb

TWiStErRob force-pushed the plugins branch from 411d01f to c7ef3eb Compare April 6, 2023 21:28

TWiStErRob added 2 commits April 7, 2023 09:55

Fix memory problems

a284ee5

Extract logic to separate function

74adb10

github-advanced-security bot found potential problems Apr 7, 2023

View reviewed changes

test/src/test/kotlin/net/twisterrob/gradle/test/fixtures/mergeGradleScriptsTest.kt Fixed Show fixed Hide fixed

test/src/test/kotlin/net/twisterrob/gradle/test/fixtures/mergeGradleScriptsTest.kt Fixed Show fixed Hide fixed

Extract self-contained enum

347fd33

TWiStErRob force-pushed the plugins branch from 71b8451 to 347fd33 Compare April 7, 2023 09:16

TWiStErRob added 2 commits April 7, 2023 10:18

Fix detekt

d5771e9

Fix copy-paste

f2a026a

TWiStErRob enabled auto-merge (squash) April 7, 2023 10:10

TWiStErRob merged commit 7c27f60 into main Apr 7, 2023

TWiStErRob deleted the plugins branch April 7, 2023 10:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize testing frameworks and test fixtures #452

Modernize testing frameworks and test fixtures #452

TWiStErRob commented Apr 6, 2023 •

edited

Loading

Modernize testing frameworks and test fixtures #452

Modernize testing frameworks and test fixtures #452

Conversation

TWiStErRob commented Apr 6, 2023 • edited Loading

TWiStErRob commented Apr 6, 2023 •

edited

Loading