Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #29 and #35: handle edge cases better #38

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Fix #29 and #35: handle edge cases better #38

merged 4 commits into from
Jan 31, 2022

Conversation

TWiStErRob
Copy link
Owner

Found #37 while developing.

@TWiStErRob TWiStErRob added the bug Something isn't working label Jan 31, 2022
@TWiStErRob TWiStErRob added this to the 1.1.1 milestone Jan 31, 2022
This was linked to issues Jan 31, 2022
NPE during update when threshold is hit #29
Closed
Going outside the threshold gives inconsistent UI #35
Closed
@TWiStErRob TWiStErRob enabled auto-merge (squash) January 31, 2022 22:02
@github-actions
Copy link

Unit Test Results

  15 files  ±0    15 suites  ±0   6s ⏱️ +2s
117 tests +5  109 ✔️ +5  8 💤 ±0  0 ❌ ±0 
191 runs  +5  183 ✔️ +5  8 💤 ±0  0 ❌ ±0 

Results for commit 490b528. ± Comparison against base commit 4190703.

@TWiStErRob TWiStErRob merged commit 41552ba into master Jan 31, 2022
@TWiStErRob TWiStErRob deleted the fix29 branch January 31, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0 - Fixes
Development

Successfully merging this pull request may close these issues.

Going outside the threshold gives inconsistent UI NPE during update when threshold is hit
1 participant
@TWiStErRob