Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix rendering broken colpos #508

Merged
merged 2 commits into from
Nov 8, 2022
Merged

[BUGFIX] Fix rendering broken colpos #508

merged 2 commits into from
Nov 8, 2022

Conversation

twoldanski
Copy link
Collaborator

fixes edge case when rendering element(s) cause render incorrect colpos with null values

@twoldanski
[BUGFIX] Fix rendering broken colpos
db170cc 
fixes edge case when rendering element(s) cause render incorrect colpos with null values
@coveralls
Copy link

coveralls commented Nov 4, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3418056192

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 64.333%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/ContentObject/JsonContentContentObject.php 0 2 0.0%
Totals Coverage Status
Change from base Build 3418054417: -0.1%
Covered Lines: 588
Relevant Lines: 914
💛 - Coveralls

@lukaszuznanski lukaszuznanski self-assigned this Nov 8, 2022
@lukaszuznanski lukaszuznanski merged commit 26e9239 into master Nov 8, 2022
@twoldanski twoldanski deleted the bugfix/skip-rendering-brokencolpos branch November 10, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszuznanski lukaszuznanski lukaszuznanski approved these changes

Assignees

@lukaszuznanski lukaszuznanski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twoldanski @coveralls @lukaszuznanski