Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX/FEATURE] Submitted form should return sent data to the frontend #547

Merged
merged 2 commits into from
Feb 17, 2023
Merged

[BUGFIX/FEATURE] Submitted form should return sent data to the frontend #547

merged 2 commits into from
Feb 17, 2023

Conversation

twoldanski
Copy link
Collaborator

Also resolves #530

@twoldanski twoldanski force-pushed the bugfix/form-translations-improvement branch from 6ce2927 to 3c072fc Compare February 8, 2023 09:46
@coveralls
Copy link

coveralls commented Feb 8, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4172946710

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 60.498%
Totals Coverage Status
Change from base Build 4124298163: 0.04%
Covered Lines: 680
Relevant Lines: 1124
💛 - Coveralls

@lukaszuznanski lukaszuznanski merged commit c2eacfc into master Feb 17, 2023
@lukaszuznanski lukaszuznanski deleted the bugfix/form-translations-improvement branch February 17, 2023 13:00
lukaszuznanski pushed a commit that referenced this pull request Feb 23, 2023
@twoldanski
[TASK] Improve form support with v12 (#554)
b433df0 
Fix fe-login flashMessages partial with fe debug enabled (#546)
Submitted form should return sent data to the frontend (#547)
Also resolves #530
* [TASK] Improve form support with v12
resolves #550
lukaszuznanski pushed a commit that referenced this pull request Mar 2, 2023
@twoldanski @lukaszuznanski
[TASK] Improve form support with v12 (#554)
f49b3c2 
Fix fe-login flashMessages partial with fe debug enabled (#546)
Submitted form should return sent data to the frontend (#547)
Also resolves #530
* [TASK] Improve form support with v12
resolves #550
twoldanski added a commit that referenced this pull request Mar 9, 2023
@twoldanski
[TASK] Improve form support with v12 (#554)
27c4c27 
Fix fe-login flashMessages partial with fe debug enabled (#546)
Submitted form should return sent data to the frontend (#547)
Also resolves #530
* [TASK] Improve form support with v12
resolves #550
twoldanski added a commit that referenced this pull request Mar 9, 2023
@twoldanski
[TASK] Improve form support with v12 (#554)
b438712 
Fix fe-login flashMessages partial with fe debug enabled (#546)
Submitted form should return sent data to the frontend (#547)
Also resolves #530
* [TASK] Improve form support with v12
resolves #550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszuznanski lukaszuznanski lukaszuznanski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom FormElement´s defaultValue = 0 gets stringified to "" (empty String)
3 participants
@twoldanski @coveralls @lukaszuznanski