Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Trim whitespaces in JSON decode helper #603

Merged
merged 2 commits into from
Jun 9, 2023
Merged

[BUGFIX] Trim whitespaces in JSON decode helper #603

merged 2 commits into from
Jun 9, 2023

Conversation

d-pietka
Copy link
Contributor

@d-pietka d-pietka commented Jun 3, 2023 •
edited
Loading

Adding trim() fixed the error when there was a space in the passed value along with one of the characters: \n \r \t \v \x00

tmotyl
tmotyl previously approved these changes Jun 5, 2023
View reviewed changes
@coveralls
Copy link

coveralls commented Jun 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5180899064

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.019%
Totals Coverage Status
Change from base Build 5153704168: 0.0%
Covered Lines: 774
Relevant Lines: 1248
💛 - Coveralls

@lukaszuznanski lukaszuznanski merged commit 80a8696 into TYPO3-Headless:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmotyl tmotyl tmotyl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-pietka @coveralls @tmotyl @lukaszuznanski