Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Improve check for empty elements #702

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

twoldanski
Copy link
Collaborator

When fetching non CE records via CONTENT_JSON we should not check for colPos, there is none.

@coveralls
Copy link

coveralls commented Feb 7, 2024

Pull Request Test Coverage Report for Build 7811837829

  • -4 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.438%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/ContentObject/JsonContentContentObject.php 0 4 0.0%
Totals Coverage Status
Change from base Build 7801134890: 0.0%
Covered Lines: 848
Relevant Lines: 1316

💛 - Coveralls

When fetching non CE records via CONTENT_JSON we should not check for colPos, there is none.
@twoldanski twoldanski force-pushed the task/fix-jsoncontentcontent branch from 942fa9c to 87d2264 Compare February 7, 2024 08:18
@lukaszuznanski lukaszuznanski merged commit d8ffe67 into master Feb 7, 2024
8 checks passed
@lukaszuznanski lukaszuznanski deleted the task/fix-jsoncontentcontent branch February 7, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants