Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] DatabaseQueryProcessor improvements #719

Merged
merged 1 commit into from
May 8, 2024
Merged

[BUGFIX] DatabaseQueryProcessor improvements #719

merged 1 commit into from
May 8, 2024

Conversation

twoldanski
Copy link
Collaborator

@twoldanski twoldanski commented Apr 23, 2024 •
edited
Loading

@coveralls
Copy link

coveralls commented Apr 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9003356172

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.411%
Totals Coverage Status
Change from base Build 9003342514: 0.0%
Covered Lines: 847
Relevant Lines: 1315
💛 - Coveralls

@twoldanski @lukaszuznanski
[BUGFIX] DatabaseQueryProcessor improvements
9da8c8d 
- restore behavior to output whole record if rendering definition is not set for query processor (solves #718)
- align menus to render less data (only uid, header & processed image if set) to match core fluid-style-content behavior & solve performance issues (solves #715)
- code cleanup
@lukaszuznanski lukaszuznanski force-pushed the bugfix/dataprocessor-fixes branch from a6e107b to 9da8c8d Compare May 8, 2024 14:13
@lukaszuznanski lukaszuznanski merged commit 8d4a2b3 into master May 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszuznanski lukaszuznanski lukaszuznanski approved these changes

@tmotyl tmotyl Awaiting requested review from tmotyl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with DatabaseQueryProcessor Endless loop in CType menu_section
3 participants
@twoldanski @coveralls @lukaszuznanski