Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Move SearchComponents to PSR-14 events #3675

Closed
bmack opened this issue Jun 5, 2023 · 0 comments · Fixed by #3676
Closed

[TASK] Move SearchComponents to PSR-14 events #3675

bmack opened this issue Jun 5, 2023 · 0 comments · Fixed by #3676

Comments

@bmack
Copy link
Collaborator

bmack commented Jun 5, 2023

We should reduce our own logic and move to TYPO3 standards as much as possible. All hooks in SearchResultSetService should actually be moved to a unified PSR-14-based setup.
bmack added a commit to bmack/ext-solr that referenced this issue Jun 5, 2023
@bmack
[!!!][FEATURE] Rework Search Component system
efd6f29 
All Search Components have been reworked and the Component
system have been moved to a PSR-14 Event
`AfterSearchQueryHasBeenPreparedEvent`.

This way, the registration works just as other PSR-14 events,
and Dependency Injection is now used consistently across all
Componenents.

The Component System is now merged with the previous hook
`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['modifySearchQuery']`
and the `ApacheSolrForTypo3\Solr\Search\Modifier` interface.

Two other hooks have been migrated as well.

Tests who actually tested the registration have been removed,
further existing tests have been adapted.

Fixes: TYPO3-Solr#3675
@bmack bmack mentioned this issue Jun 5, 2023
Merged
dkd-kaehm pushed a commit to bmack/ext-solr that referenced this issue Jun 5, 2023
@bmack @dkd-kaehm
[!!!][FEATURE] Rework Search Component system
71fe543 
All Search Components have been reworked and the Component
system have been moved to a PSR-14 Event
`AfterSearchQueryHasBeenPreparedEvent`.

This way, the registration works just as other PSR-14 events,
and Dependency Injection is now used consistently across all
Componenents.

The Component System is now merged with the previous hook
`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['modifySearchQuery']`
and the `ApacheSolrForTypo3\Solr\Search\Modifier` interface.

Two other hooks have been migrated as well.

Tests who actually tested the registration have been removed,
further existing tests have been adapted.

Fixes: TYPO3-Solr#3675
dkd-kaehm pushed a commit that referenced this issue Jun 5, 2023
@bmack @dkd-kaehm
[!!!][FEATURE] Rework Search Component system
e8cd090 
All Search Components have been reworked and the Component
system have been moved to a PSR-14 Event
`AfterSearchQueryHasBeenPreparedEvent`.

This way, the registration works just as other PSR-14 events,
and Dependency Injection is now used consistently across all
Componenents.

The Component System is now merged with the previous hook
`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['modifySearchQuery']`
and the `ApacheSolrForTypo3\Solr\Search\Modifier` interface.

Two other hooks have been migrated as well.

Tests who actually tested the registration have been removed,
further existing tests have been adapted.

Fixes: #3675
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Feb 6, 2024
@dkd-friedrich
[BUGFIX] Prevent exception in AcessComponent
2324d83 
AccessComponent expects to find the TypoScriptFrontendController in
$GLOBALS['TSFE'], and will cause an exception in CLI context.

To prevent this an additional check for TSFE in AccessComponent is
added, similiar to other components like LastSearchesComponent.

Relates: TYPO3-Solr#3675
Resolves: TYPO3-Solr#3944
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Feb 6, 2024
@dkd-friedrich
[BUGFIX] Prevent exception in AccessComponent
cd1c6c3 
AccessComponent expects to find the TypoScriptFrontendController in
$GLOBALS['TSFE'], and will cause an exception in CLI context.

To prevent this an additional check for TSFE in AccessComponent is
added, similiar to other components like LastSearchesComponent.

Relates: TYPO3-Solr#3675
Resolves: TYPO3-Solr#3944
@dkd-friedrich dkd-friedrich mentioned this issue Feb 6, 2024
Merged
dkd-friedrich added a commit that referenced this issue Feb 6, 2024
@dkd-friedrich
[BUGFIX] Prevent exception in AccessComponent
5e78ce8 
AccessComponent expects to find the TypoScriptFrontendController in
$GLOBALS['TSFE'], and will cause an exception in CLI context.

To prevent this an additional check for TSFE in AccessComponent is
added, similiar to other components like LastSearchesComponent.

Relates: #3675
Resolves: #3944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[!!!][FEATURE] Rework Search Component system bmack/ext-solr
1 participant
@bmack