Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Unify naming of PSR-14 events #3681

Closed
Tracked by #3376
bmack opened this issue Jun 5, 2023 · 0 comments · Fixed by #3682
Closed
Tracked by #3376

[TASK] Unify naming of PSR-14 events #3681

bmack opened this issue Jun 5, 2023 · 0 comments · Fixed by #3682

Comments

@bmack
Copy link
Collaborator

bmack commented Jun 5, 2023

EXT:solr should ship with a unified naming of all events that are triggered in this extension
bmack added a commit to bmack/ext-solr that referenced this issue Jun 5, 2023
@bmack
[TASK] Rename previously created PSR-14 events
d953ec7 
New namings:

* `ApacheSolrForTypo3\Solr\Event\Indexing\AfterIndexItemEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\AfterItemHasBeenIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\AfterIndexItemsEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\AfterItemsHaveBeenIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeIndexItemEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeItemIsIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeIndexItemsEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeItemsAreIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Parser\AfterFacetParsedEvent` is now called `ApacheSolrForTypo3\Solr\Event\Parser\AfterFacedIsParsedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\PostProcessUriEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\AfterUriIsProcessedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\BeforeProcessCachedVariablesEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\BeforeCachedVariablesAreProcessedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\BeforeReplaceVariableInCachedUrlEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\BeforeVariableInCachedUrlAreReplacedEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\AfterFrequentlySearchedEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\AfterFrequentlySearchHasBeenExecutedEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\AfterSearchEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\BeforeSearchResultIsShownEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\FormEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\BeforeSearchFormIsShownEvent`

Fixes: TYPO3-Solr#3681
@bmack bmack mentioned this issue Jun 5, 2023
Merged
@dkd-kaehm dkd-kaehm mentioned this issue Jun 6, 2023
Closed
68 tasks
bmack added a commit to bmack/ext-solr that referenced this issue Jun 6, 2023
@bmack
[TASK] Rename previously created PSR-14 events
1fdf7dd 
New namings:

* `ApacheSolrForTypo3\Solr\Event\Indexing\AfterIndexItemEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\AfterItemHasBeenIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\AfterIndexItemsEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\AfterItemsHaveBeenIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeIndexItemEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeItemIsIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeIndexItemsEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeItemsAreIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Parser\AfterFacetParsedEvent` is now called `ApacheSolrForTypo3\Solr\Event\Parser\AfterFacetIsParsedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\PostProcessUriEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\AfterUriIsProcessedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\BeforeProcessCachedVariablesEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\BeforeCachedVariablesAreProcessedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\BeforeReplaceVariableInCachedUrlEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\BeforeVariableInCachedUrlAreReplacedEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\AfterFrequentlySearchedEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\AfterFrequentlySearchHasBeenExecutedEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\AfterSearchEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\BeforeSearchResultIsShownEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\FormEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\BeforeSearchFormIsShownEvent`

Documentation has been updated

Fixes: TYPO3-Solr#3681
dkd-kaehm pushed a commit that referenced this issue Jun 6, 2023
@bmack @dkd-kaehm
[TASK] Rename previously created PSR-14 events
4c96b41 
New namings:

* `ApacheSolrForTypo3\Solr\Event\Indexing\AfterIndexItemEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\AfterItemHasBeenIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\AfterIndexItemsEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\AfterItemsHaveBeenIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeIndexItemEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeItemIsIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeIndexItemsEvent` is now called `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeItemsAreIndexedEvent`
* `ApacheSolrForTypo3\Solr\Event\Parser\AfterFacetParsedEvent` is now called `ApacheSolrForTypo3\Solr\Event\Parser\AfterFacetIsParsedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\PostProcessUriEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\AfterUriIsProcessedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\BeforeProcessCachedVariablesEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\BeforeCachedVariablesAreProcessedEvent`
* `ApacheSolrForTypo3\Solr\Event\Routing\BeforeReplaceVariableInCachedUrlEvent` is now called `ApacheSolrForTypo3\Solr\Event\Routing\BeforeVariableInCachedUrlAreReplacedEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\AfterFrequentlySearchedEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\AfterFrequentlySearchHasBeenExecutedEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\AfterSearchEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\BeforeSearchResultIsShownEvent`
* `ApacheSolrForTypo3\Solr\Event\Search\FormEvent` is now called `ApacheSolrForTypo3\Solr\Event\Search\BeforeSearchFormIsShownEvent`

Documentation has been updated

Fixes: #3681
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Oct 9, 2023
@dkd-friedrich
[BUGFIX] Fix facet route enhancer
46555d2 
Renaming of 3 events related to routing caused failures in route
generation in TYPO3 12. This commit replaces the old events
in all occurences missed in the first step and restores the
route enhancer functions.

Relates: TYPO3-Solr#3681
Relates: TYPO3-Solr#3810
dkd-kaehm pushed a commit that referenced this issue Oct 10, 2023
@dkd-friedrich @dkd-kaehm
[BUGFIX] Fix facet route enhancer
3c402b4 
Renaming of 3 events related to routing caused failures in route
generation in TYPO3 12. This commit replaces the old events
in all occurences missed in the first step and restores the
route enhancer functions.

Relates: #3681
Relates: #3810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TASK] Rename previously created PSR-14 events bmack/ext-solr
1 participant
@bmack