[TASK:T12] Replace SignalSlot with EventDispatcher #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
3l73
changed the title
68 tasks
dkd-kaehm
force-pushed
the
task/3376-TYPO3_12_compatibility
branch
from
cdfc1ac to
c444f0e
Compare
dkd-kaehm
force-pushed
the
task/3437-Replace_signal_slot_with_event_dispatcher
branch
from
fb5cc50 to
f84d097
Compare
|
Please do rebase without pulling the state(I did no changes!). The commit is because i tried the GitHub UI "resolve conflicts", this creates the merge commit :/ which is not fine for our flows. |
3l73
force-pushed
the
task/3437-Replace_signal_slot_with_event_dispatcher
branch
from
f84d097 to
cc6f208
Compare
dkd-kaehm
previously approved these changes
Jan 20, 2023
The signal-slot technology was deprecated and now replaced threw the EventDispatcher. Remove old documentation about signal slot. Resolves: TYPO3-Solr#3376
dkd-kaehm
force-pushed
the
task/3437-Replace_signal_slot_with_event_dispatcher
branch
from
cc6f208 to
4a820d4
Compare
dkd-kaehm
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
This pull request replaces the old signal slot technology with the PSR-14 event dispatcher.
beforeIndexItemsreplaced by event\ApacheSolrForTypo3\Solr\Event\Indexing\BeforeIndexItemsEventbeforeIndexItemreplaced by event\ApacheSolrForTypo3\Solr\Event\Indexing\BeforeIndexItemEventafterIndexItemreplaced by event\ApacheSolrForTypo3\Solr\Event\Indexing\AfterIndexItemEventafterIndexItemsreplaced by event\ApacheSolrForTypo3\Solr\Event\Indexing\AfterIndexItemsEventresultsActionreplaced by event\ApacheSolrForTypo3\Solr\Event\Search\AfterSearchEventformActionreplaced by event\ApacheSolrForTypo3\Solr\Event\Search\FormEventfrequentlySearchedActionreplaced by event\ApacheSolrForTypo3\Solr\Event\Search\AfterFrequentlySearchedEventoptionsParsedreplaced by event\ApacheSolrForTypo3\Solr\Event\Parser\AfterFacetParsedEventHow to test
Please add a testing instruction here
Fixes: #3437