Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK:T12] Migrate backend module registration #3471

Conversation

3l73
Copy link
Collaborator

@3l73 3l73 commented Jan 25, 2023

What this pr does

Migrate the backend modules for TYPO3 12

How to test

Please add a testing instruction here

Relates: #3376

@3l73 3l73 force-pushed the task/3376-Migrate_backend_modul_registration branch from ede25e8 to acfa620 Compare January 25, 2023 15:45
@3l73 3l73 requested a review from dkd-kaehm January 30, 2023 06:59
@dkd-kaehm dkd-kaehm force-pushed the task/3376-TYPO3_12_compatibility branch from b15a4c3 to d33ba81 Compare February 3, 2023 12:42
@dkd-kaehm dkd-kaehm force-pushed the task/3376-Migrate_backend_modul_registration branch from 7f76b60 to 86e7d88 Compare February 3, 2023 12:56
3l73 added 4 commits February 3, 2023 20:02
Move the backend modul registration into Configuration/Backend/Modules.php

Resolves: TYPO3-Solr#3376
Move the icon registration into Configuration/Icons.php

Resolves: TYPO3-Solr#3376
Configure folder for backend controller and backend view helper as service.

Resolves: TYPO3-Solr#3376
Adjust method signatures.

Resolves: TYPO3-Solr#3376
@dkd-kaehm dkd-kaehm force-pushed the task/3376-Migrate_backend_modul_registration branch from 86e7d88 to 36cc242 Compare February 3, 2023 19:03
@dkd-kaehm dkd-kaehm marked this pull request as ready for review February 10, 2023 11:29
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
The state is OK for now.
We'll proceed the task if other components not blocking functionality of BE Modules.

@dkd-kaehm dkd-kaehm merged commit f84c9a1 into TYPO3-Solr:task/3376-TYPO3_12_compatibility Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants