Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix value resolution in SOLR_RELATION #3475

Merged

Conversation

dkd-friedrich
Copy link
Member

What this pr does

This changeset fixes issues with the resolution of values in SOLR_RELATION, fixed is the resolution of:

  • foreignLabelFields (2nd level+)
  • multiple values in m:n relations
  • nested m:n relations
  • nested multi values

Additionally the missing stdWrap functionality on values from mm relations is added.

Integration tests are added to ensure the right behaviour of SOLR_RELATION.

How to test

Test scenarios are added in RelationTest

For manual testing:

  • Create a table A with an 1:m relation to table B
  • In table B create an n:m relation to table C
  • Configure indexing for table A with a multi value field that should contain all relations to table C
  • Index the records
  • Relations must be resolved correctly

Resolves: #3152
Resolves: #3408

This commit fixes issues with the resolution of values in SOLR_RELATION,
fixed is the resolution of:
- foreignLabelFields (2nd level+)
- multiple values in m:n relations
- nested m:n relations
- nested multi values

Additionally the missing stdWrap functionality on values from mm
relations is added.

Integration tests are added to ensure the right behaviour of
SOLR_RELATION.

Resolves: TYPO3-Solr#3152
Resolves: TYPO3-Solr#3408
@dkd-friedrich dkd-friedrich force-pushed the task/main/3152-fix_solr_relation branch from 7d7eaa8 to dd8970e Compare January 27, 2023 16:42
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants